Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(esbuild): wrap all the logic inside a plugin #829

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

refactor(esbuild): wrap all the logic inside a plugin #829

wants to merge 1 commit into from

Conversation

oscard0m
Copy link
Member

@oscard0m oscard0m commented Apr 7, 2023

Description

Wrap all the logic of scripts/build.mjs in an in-house ESBuild plugin.

The idea would be to publish our ESBuild Octokit plugin and centralize the changes we want to do in the future.

We would need a /scripts/build.mjs which calls ESBuild with this plugin but that should remain static (and still would have the door open to passing options to our plugin in case we have a repo with special requirements).

@wolfy1339 What do you think about this?

@oscard0m oscard0m requested a review from wolfy1339 April 7, 2023 15:31
@oscard0m oscard0m mentioned this pull request Apr 7, 2023
Closed
5 tasks
@wolfy1339
Copy link
Member

This looks good and I like the idea.

We'd most likely have to get another repo and npm package set up for this

@oscard0m
Copy link
Member Author

oscard0m commented Apr 7, 2023

This looks good and I like the idea.

We'd most likely have to get another repo and npm package set up for this

I propose doing this:

  1. Let's land build: replace pika with esbuild and tsc #819 and we can see if this causes friction to users or not and land the appropriate fixes if necessary. Let's wait before scaffolding this to the rest of the repositories.
  2. I'll update this PR to make it a refactor of what you land in step 1 and I will tag the core team to see if they like the idea and ask for that repo and npm package.
  3. Depending if they take time to answer or not we can publish it in our personal GitHub until we get an answer but I hope to get an answer soon (and I hope they like the idea).

Sounds good to you? @wolfy1339

@wolfy1339
Copy link
Member

Absolutely sounds good 👍

@wolfy1339 wolfy1339 added the Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR label Apr 7, 2023
@oscard0m oscard0m force-pushed the esbuild branch 2 times, most recently from 76fa6aa to 8992e9c Compare April 7, 2023 20:22
@wolfy1339 wolfy1339 changed the base branch from esbuild to main April 12, 2023 21:08
@wolfy1339 wolfy1339 mentioned this pull request Apr 14, 2023
Merged
5 tasks
@oscard0m @wolfy1339
refactor(esbuild): wrap all the logic inside a plugin
53c5959 
the idea is to publish this plugin so we can centralize the logic in one place and replicate it to
all the repositories easily
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wolfy1339 wolfy1339 Awaiting requested review from wolfy1339

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
🧰 Octokit Active
Status: 🏗 In progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oscard0m @wolfy1339